Phoenix500526 opened a new pull request, #23712:
URL: https://github.com/apache/datafusion/pull/23712
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #23508 .
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
`SortMergeJoinExec` serialization currently depends on centralized
encoding and decoding logic in `datafusion-proto`. This keeps protobuf
ownership separate from the execution plan and contributes to the
central type-dispatch chain tracked by #23494.
Moving serialization into `SortMergeJoinExec` keeps the implementation
with the plan that owns the relevant state and aligns it with the new
per-plan serialization model.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
- Add `ExecutionPlan::try_to_proto` for `SortMergeJoinExec`.
- Add `SortMergeJoinExec::try_from_proto`.
- Preserve serialization of:
- Both child plans.
- Join-key expressions.
- Join type and null-equality behavior.
- Optional join filters and column origins.
- Per-key sort options.
- Convert `JoinType`, `JoinSide`, and `NullEquality` through exhaustive
by-name matches.
- Route decoding through the plan-local implementation and remove the
centralized encoding downcast.
- Retain the old public conversion helpers as deprecated compatibility
APIs.
- Preserve the existing protobuf wire representation.
- Expand roundtrip coverage for every join type, both null-equality
modes, filters, column origins, and non-default sort options.
## Are these changes tested?
Yes
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
There are no runtime behavior or protobuf wire-format changes.
The old `PhysicalPlanNodeExt` conversion helpers remain available but
are deprecated in favor of the plan-local serialization hooks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
