0lai0 opened a new pull request, #4974:
URL: https://github.com/apache/datafusion-comet/pull/4974
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Part of #4834 (DATE ORDER BY only; DECIMAL remains a follow-up)
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Native windows used to fall back to Spark for `RANGE` frames with an
explicit `PRECEDING` / `FOLLOWING` offset when `ORDER BY` was `DATE`. Spark
ships that offset as an integer literal, but arrow-arith rejects `Date32 +
Int32` and requires an `Interval` RHS.
This PR coerces the offset to `IntervalDayTime` when the ORDER BY column is
`Date32`, so boundary math uses `Date32 + IntervalDayTime` and the DATE
fallback can be removed. `UNBOUNDED` / `CURRENT ROW` already ran natively;
DECIMAL still falls back.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
- Native planner : coerce `Int32` / `Int64` RANGE offsets to
`IntervalDayTime` for `Date32` ORDER BY.
- Scala serde : drop the `DateType` RANGE fallback; keep the DECIMAL
fallback.
- Tests : 7 cases in `CometWindowExecSuite` (offsets, duplicate dates,
nulls, unbounded baseline).
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
`./mvnw test -Dtest=none
-Dsuites="org.apache.comet.exec.CometWindowExecSuite"
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
