MassivePizza commented on PR #23609:
URL: https://github.com/apache/datafusion/pull/23609#issuecomment-5001495326

   Only getting noise locally. I don't think my changes should affect "no TopK" 
regardless.
   ```
   distinct 10000000 rows desc [no TopK]
                           time:   [29.979 ms 30.184 ms 30.388 ms]
                           change: [−0.4089% +0.4916% +1.3107%] (p = 0.27 > 
0.05)
                           No change in performance detected.
   
   distinct 10000000 rows asc [no TopK]
                           time:   [30.436 ms 30.733 ms 31.053 ms]
                           change: [+1.5647% +2.7108% +3.9667%] (p = 0.00 < 
0.05)
                           Performance has regressed.
   Found 6 outliers among 100 measurements (6.00%)
     5 (5.00%) high mild
     1 (1.00%) high severe
   
   distinct 10000000 rows desc [TopK]
                           time:   [4.5273 ms 4.5704 ms 4.6145 ms]
                           change: [−23.068% −22.347% −21.532%] (p = 0.00 < 
0.05)
                           Performance has improved.
   Found 1 outliers among 100 measurements (1.00%)
     1 (1.00%) high mild
   
   distinct 10000000 rows asc [TopK]
                           time:   [4.3722 ms 4.3967 ms 4.4224 ms]
                           change: [−25.664% −24.988% −24.372%] (p = 0.00 < 
0.05)
                           Performance has improved.
   Found 3 outliers among 100 measurements (3.00%)
     2 (2.00%) high mild
     1 (1.00%) high severe
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to