ariel-miculas commented on code in PR #23606:
URL: https://github.com/apache/datafusion/pull/23606#discussion_r3594953950
##########
datafusion/physical-plan/src/sorts/merge.rs:
##########
@@ -375,7 +385,10 @@ impl<C: CursorValues> SortPreservingMergeStream<C> {
let _ = cursor.advance();
if cursor.is_finished() {
// Take the current cursor, leaving `None` in its place
- self.prev_cursors[stream_idx] =
self.cursors[stream_idx].take();
+ let taken = self.cursors[stream_idx].take();
+ if self.enable_round_robin_tie_breaker {
Review Comment:
this makes sense, although fixing this issue in the other PR will cause this
change to be less effective, since we'll only store the single Row instead of
the entire cursor;
the purpose of this change was more for demonstrating the issue in the unit
tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
