avantgardnerio opened a new pull request, #2045: URL: https://github.com/apache/datafusion-ballista/pull/2045
## Summary Follow-up to review feedback on #2038: split the `task_slots` → `vcores` rename into its own PR so it can land independently. Mechanical rename, no behavior change. Follows the YARN precedent (`yarn.nodemanager.resource.cpu-vcores`) and Spark's `spark.executor.cores`. The `v` prefix is self-documenting — readers grepping in a year don't have to hunt for a doc comment to know these aren't physical `nproc`. It also leaves room for future execution models that decouple "how many tasks" from "how many cores per task." ## What changed - `ExecutorSpecification.task_slots` → `vcores` (u32), with a YARN/Spark doc comment - Proto: `ExecutorResource.task_slots` → `vcores`, `AvailableTaskSlots` → `AvailableVcores`, `ExecutorTaskSlots` → `ExecutorVcores`, `PollWorkParams.num_free_slots` → `num_free_vcores`. Field numbers preserved for wire compat. - CLI: `--concurrent-tasks` → `--vcores` on both `ballista-executor` and `ballista-cli` - Cluster bookkeeping: `InMemoryClusterState.task_slots` → `available_vcores` - TUI: "Task Slots" column → "vCores" - Docs, `docker-compose.yml`, tpch workflow, and CLI README updated so `--concurrent-tasks` invocations don't fail at boot under the new flag name - Historical changelogs left untouched ## Test plan - [x] \`cargo check --workspace --all-targets\` - [x] \`cargo clippy --workspace --all-targets -- -D warnings\` - [x] \`cargo test -p ballista-scheduler --lib\` (224 tests) - [x] \`cargo test -p ballista-core --lib\` (116 tests) - [x] Proto codegen produces no diff after build 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
