mbutrovich commented on PR #4927: URL: https://github.com/apache/datafusion-comet/pull/4927#issuecomment-4985857325
The description says the PR replaces "the per-value byte scan" with "a single vectorizable column-wide escape scan." The diff does no such thing. String escaping is still per value inside the row loop via `escape_string(string_value)` in the `FieldStyle::Quoted` arm. What the PR actually removed is the per-value `is_infinity`/`is_nan` call for Raw types via `never_renders_special_float`, not the escape scan. - Evidence: to_json.rs `FieldStyle::Quoted` arm calls `escape_string(string_value)` once per row; there is no precomputed per-column escaped buffer anywhere in the diff. - Suggested change: reword the description to describe what actually changed (prefix precompute, direct-to-builder writes, right-sized buffer, and skipping the special-float check for types that cannot render `NaN`/`Infinity`). Do not claim a vectorized escape pass that is not present. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
