alamb commented on code in PR #23528:
URL: https://github.com/apache/datafusion/pull/23528#discussion_r3590582807
##########
datafusion/physical-optimizer/src/utils.rs:
##########
@@ -220,3 +233,77 @@ pub(crate) fn
range_partitioning_satisfies_key_partitioning(
pub fn is_limit(plan: &Arc<dyn ExecutionPlan>) -> bool {
plan.is::<GlobalLimitExec>() || plan.is::<LocalLimitExec>()
}
+
+#[cfg(test)]
Review Comment:
Can you please write these tests as `.slt` rather than rust unit tests? That
will make it easier to validate that it is hooked up into the right place
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
