timsaucer commented on code in PR #23622:
URL: https://github.com/apache/datafusion/pull/23622#discussion_r3590405940
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -3887,6 +3926,29 @@ mod tests {
Ok(())
}
+ #[tokio::test]
+ async fn scalar_subquery_in_extension_expr_plans() -> Result<()> {
+ let subquery = LogicalPlanBuilder::empty(true)
+ .project(vec![lit(42_i32)])?
+ .build()?;
+ let logical_plan = LogicalPlan::Extension(Extension {
+ node: Arc::new(NoOpExtensionNode {
+ expressions: vec![scalar_subquery(Arc::new(subquery))],
+ ..Default::default()
+ }),
+ });
+ let planner =
DefaultPhysicalPlanner::with_extension_planners(vec![Arc::new(
+ ExpressionExtensionPlanner,
+ )]);
+
+ let plan = planner
+ .create_initial_plan(&logical_plan, &make_session_state())
+ .await?;
+
+ assert_contains!(format!("{plan:?}"), "ScalarSubqueryExec");
+ Ok(())
+ }
Review Comment:
If you run this test without the other changes, you will get a failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
