adriangb commented on PR #23104:
URL: https://github.com/apache/datafusion/pull/23104#issuecomment-4983412248
The failing CI (`linux build test`, and the cascading `hash collisions` /
`extended_tests`) is a single `E0063`: the `#[cfg(test)]` helper
`make_accumulator_for_test` in
`datafusion/physical-plan/src/joins/hash_join/shared_bounds.rs` was missed when
the `null_aware` field was added to `SharedBuildAccumulator`. (The other test
helper, `make_partitioned_accumulator_for_test`, was updated, which is why it
wasn't obvious.)
The fix is one line — add `null_aware: false,` to that struct literal
(around line 815):
```rust
on_right,
repartition_random_state: SeededRandomState::with_seed(1),
probe_schema: test_probe_schema(),
null_aware: false,
}
}
```
Verified `cargo test -p datafusion-physical-plan --lib --no-run` compiles
clean with this on top of the current head. (The earlier semver-checks bot
comment about `try_pushdown_through_join_with_column_indices` was a false
positive from being behind `main`, and the merge already resolved it.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
