Jefffrey commented on code in PR #23224:
URL: https://github.com/apache/datafusion/pull/23224#discussion_r3586961146
##########
datafusion/sqllogictest/test_files/datetime/timestamps.slt:
##########
@@ -82,7 +82,7 @@ SET TIME ZONE = '+08'
query T
select arrow_typeof(now());
----
-Timestamp(ns, "+08")
+Timestamp(ns, "+08:00")
Review Comment:
hm i wonder if this is significant
i wonder if we have some precedent from other engines (duckdb, spark) if
they handle in a similar way or not
##########
datafusion/core/tests/user_defined/user_defined_scalar_functions.rs:
##########
@@ -1980,7 +1985,7 @@ async fn test_config_options_work_for_scalar_func() ->
Result<()> {
});
let mut config = SessionConfig::new();
- config.options_mut().execution.time_zone = Some("AEST".into());
+ config.options_mut().execution.time_zone =
Some("Australia/Sydney".parse().unwrap());
Review Comment:
this change is interesting; were the tests just flawed previously and `AEST`
was never a valid timezone (but we never tried parsing it)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
