gabotechs commented on code in PR #23584:
URL: https://github.com/apache/datafusion/pull/23584#discussion_r3585094680
##########
datafusion/physical-plan/src/joins/utils.rs:
##########
@@ -146,9 +147,16 @@ pub fn adjust_right_output_partitioning(
Partitioning::Hash(new_exprs, *size)
}
Partitioning::Range(range) => {
- // Range partitioning optimizer propagation is tracked in
- // https://github.com/apache/datafusion/issues/22395
- Partitioning::UnknownPartitioning(range.partition_count())
+ let ordering = add_offset_to_physical_sort_exprs(
+ range.ordering().iter().cloned(),
+ left_columns_len as _,
+ )?;
+ let ordering = LexOrdering::new(ordering)
+ .expect("offsetting a range ordering keeps it non-empty");
+ Partitioning::Range(RangePartitioning::new(
Review Comment:
Rather than panicking, can we through a controlled internal error here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
