phillipleblanc commented on code in PR #2037:
URL:
https://github.com/apache/datafusion-ballista/pull/2037#discussion_r3583976542
##########
ballista/scheduler/src/state/task_manager.rs:
##########
@@ -655,67 +664,117 @@ impl<T: 'static + AsLogicalPlan, U: 'static +
AsExecutionPlan> TaskManager<T, U>
Ok(events)
}
+ /// Save a terminal job snapshot and remove it from the active cache.
+ pub(crate) async fn persist_terminal_and_evict(
+ &self,
+ job_id: &JobId,
+ snapshot: &ExecutionGraphBox,
+ ) -> Result<()> {
+ if let Some(mut job_info) = self.active_job_cache.get_mut(job_id) {
+ job_info.status = snapshot.status().status.clone();
+ }
+
+ let mut attempt = 0;
+ let save_result = loop {
Review Comment:
I've updated this:
https://github.com/apache/datafusion-ballista/compare/df258a882968ddbc1f6cc1412c2fd32647417fc1..610b4c1df6f78ae556a0d69d8660dd197983762b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
