parthchandra commented on code in PR #4930:
URL: https://github.com/apache/datafusion-comet/pull/4930#discussion_r3583931993
##########
spark/src/test/scala/org/apache/comet/parquet/CometParquetWriterSuite.scala:
##########
@@ -138,6 +142,70 @@ class CometParquetWriterSuite extends CometTestBase {
}
}
+ test("parquet write with each supported compression codec") {
Review Comment:
Not a requirement but do you think it might be useful to add a test to cover
codec precedence? I.e. specify zstd in the conf, but then override it to gzip
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
