moshap-firebolt commented on code in PR #2404:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2404#discussion_r3581750337
##########
src/parser/mod.rs:
##########
@@ -18870,6 +18870,14 @@ impl<'a> Parser<'a> {
let duplicate_treatment = self.parse_duplicate_treatment()?;
let args = self.parse_comma_separated(Parser::parse_function_args)?;
+ // GoogleSQL inline aggregate filter: `AGG(expr WHERE cond [ORDER BY
..])`.
+ // Precedes ORDER BY / LIMIT / HAVING; equivalent to `AGG(expr) FILTER
(WHERE cond)`.
+ if dialect_of!(self is GenericDialect | BigQueryDialect)
+ && self.parse_keyword(Keyword::WHERE)
Review Comment:
Yes - but it is not a standard syntax, it is really a BigQuery's shortcut
for standard FILTER(WHERE ...) clause. So I don't think it should be enabled
for all dialects. Let me know whether you still want to have it unconditionally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
