cetra3 opened a new pull request, #23565: URL: https://github.com/apache/datafusion/pull/23565
## Which issue does this PR close? - Closes https://github.com/apache/datafusion/issues/23564 ## Rationale for this change Spill files inflate string views via GC. I.e, a highly deduped string view can inflate considerably causing more memory and disk pressure. ## What changes are included in this PR? There is a new method added in the spill path to GC & Dedup string views ## Are these changes tested? Yes they are covered by existing tests. **However:** I would like to make sure we run benchmarks with external sorting to see if this is a considerable regression. My instinct will tell me that, counterintuitively, this might be a performance *increase* when externally sorting since there is less bytes being moved around. ## Are there any user-facing changes? No this is an internal method change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
