vito1317 commented on issue #15511: URL: https://github.com/apache/datafusion/issues/15511#issuecomment-4967196046
take Proposal for a first increment, keeping the CI-cost concerns discussed above in mind: - a `benchmarks-smoke` job in the extended tests workflow, gated to merges to `main` / release branches and manual dispatch (not PRs) - `cargo check` all benchmark bins and benches first — this alone catches the most common "benchmark silently broken" failures cheaply - then run a representative subset end-to-end on small data, one query each, as a "does it still run" check (explicitly not a performance measurement): `tpch`, `tpch_mem`, `sort_tpch`, `external_aggr` on TPC-H SF1 (generated with tpchgen-cli), plus `cancellation` (generates its own data) - includes a small `bench.sh` fix: the TPC-H answers copy used `docker run -it`, which fails without a TTY in CI Benchmarks needing multi-GB downloads (clickbench, h2o, imdb, tpcds) are left out of the first pass; coverage can be extended once the approach looks right. PR incoming. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
