martin-g commented on PR #2014: URL: https://github.com/apache/datafusion-ballista/pull/2014#issuecomment-4958547804
> I have no idea what any of this means Any of what ? :-) The explanation in the PR description ?! I will test it soon but the idea of using different pixel sizes was to support resizing of the terminal application (Ghostty, Tilix, iTerm2, ...). Using a specific PixelSize (like Quadrant) will work well if the terminal application is "big enough", but if the user resizes it to a smaller size then the banner will overlap with the navigation buttons in the top-right area. There is another problem with tui-big-text in the web rendered version too. There we use an `<img>` with an absolute CSS position over the generated `<canvas>` HTML element for the logo. Maybe `PixelSize::Quadrant` fixes it for the web rendering too. So, yes - the banner/logo is problematic... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
