ratmice commented on PR #23387: URL: https://github.com/apache/datafusion/pull/23387#issuecomment-4932562540
Alas, I think there is one more thing to do here: I just tried to use this to set up a custom `SessionStateBuilder` ... `with_type_planner(...)` call, and It feels like this doesn't allow you to call `SessionContext::new_with_state` for the context returned by `from_args`. (from there you can still use the `exec_from_repl` whose `CliContext::session_state` can return a custom state. But it just feels off, because it looks like `SessionContext`, and `CliSessionContext` have two different `SessionState` values. It feels to me that this calls for a builder API... ``` CliSession::builder().session_context(SessionContext::new_with_state(...)).args(args).build() ``` Then if you don't suppy the builder with one via `session_context` It can just build a default one. anyhow, I'm going to try that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
