gene-bordegaray commented on code in PR #23184:
URL: https://github.com/apache/datafusion/pull/23184#discussion_r3532822517
##########
datafusion/physical-optimizer/src/ensure_requirements/enforce_distribution.rs:
##########
@@ -942,8 +943,11 @@ struct RepartitionRequirementStatus {
/// Designates whether round robin partitioning is beneficial according to
/// the statistical information we have on the number of rows.
roundrobin_beneficial_stats: bool,
- /// Designates whether hash partitioning is necessary.
- hash_necessary: bool,
+ /// Designates whether hash repartitioning is required.
+ hash_repartition_required: bool,
Review Comment:
the idea was that we are specifically having logic for hash repartitioning
right now in the rule, then if / when we decide to add logic for range
repartitioning there will be distinction
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
