buraksenn commented on code in PR #23306:
URL: https://github.com/apache/datafusion/pull/23306#discussion_r3523527926
##########
datafusion/functions-nested/src/resize.rs:
##########
@@ -342,12 +350,27 @@ where
)?))
}
+/// Largest element count whose eager value buffer stays within `isize::MAX`
+/// bytes, so `array_resize` rejects oversized results instead of panicking.
+/// Only primitive and `FixedSizeBinary` leaves are byte-exact.
+fn max_resize_values(value_type: &DataType) -> usize {
Review Comment:
Since there are parameterized types I would need to keep match right? I'm
not sure it would be better but can't say I've a strong opinion. If you say go
for it I can change it that way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
