andygrove opened a new pull request, #1941: URL: https://github.com/apache/datafusion-ballista/pull/1941
# Which issue does this PR close? Closes #1940. # Rationale for this change #1924 added support for submitting an already-built physical plan to the scheduler. To carry both a logical and a physical plan, it changed the parameter of two public methods — `SchedulerServer::submit_job` and `TaskManager::submit_job` — from `&LogicalPlan` to a new `&SubmitPlan` enum. That is a breaking change for anyone driving the scheduler programmatically: existing `submit_job(&logical_plan)` calls no longer compile. 54.0.0 has not been released yet, so we can keep the new capability without breaking the existing API. # What changes are included in this PR? - Restore `SchedulerServer::submit_job` and `TaskManager::submit_job` to their original `&LogicalPlan` signatures (unchanged for existing callers). - Add `SchedulerServer::submit_physical_plan` and `TaskManager::submit_physical_plan`, taking `Arc<dyn ExecutionPlan>`, for the already-built-physical-plan path. - Extract the shared logic into a `submit_plan(&SubmitPlan)` method on each type; the `submit_job` / `submit_physical_plan` methods are thin wrappers over it. `SubmitPlan`, the job-queued event, and the wire format are unchanged. - Internal callers use `submit_plan` directly (the gRPC handler already holds a `SubmitPlan`; `SchedulerState::submit_job` — which is `pub(crate)` — forwards to `task_manager.submit_plan`). - The tests that #1924 rewrote to construct a `SubmitPlan` are reverted to pass a `&LogicalPlan` through the restored `submit_job`, and a new test covers `submit_physical_plan`. # Are there any user-facing changes? The public `submit_job(&LogicalPlan)` API is preserved (no breaking change). A new `submit_physical_plan` method is added. No wire-format or configuration changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
