ametel01 commented on PR #23284: URL: https://github.com/apache/datafusion/pull/23284#issuecomment-4879003765
> Is there some test that fails without this PR and passes with it? I updated the regression test so it now fails on `main` and passes with this PR. Specifically, `test_expr_to_sql_does_not_mutate_recursive_minimum_stack_size` observes `recursive::get_minimum_stack_size()` from inside `Unparser::expr_to_sql`. On `main` with only this test applied, it fails because the old `StackGuard` changes the process-global minimum from 128 KiB to 256 KiB: left: 262144 right: 131072 With this PR, the test passes because the unparser uses local `stacker::maybe_grow` boundaries and leaves the global recursive minimum unchanged. I also ran: - `cargo test -p datafusion-sql` - `cargo test -p datafusion-sql --features recursive_protection` - `./dev/rust_lint.sh` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
