alamb commented on code in PR #23312:
URL: https://github.com/apache/datafusion/pull/23312#discussion_r3521613982
##########
datafusion-examples/examples/flight/server.rs:
##########
@@ -112,7 +112,7 @@ impl FlightService for FlightServiceImpl {
// add an initial FlightData message that sends schema
let options = arrow::ipc::writer::IpcWriteOptions::default();
- let mut compression_context = CompressionContext::default();
+ let mut compression_context = IpcWriteContext::default();
Review Comment:
Struct was renamed (old was deprecated) in
- https://github.com/apache/arrow-rs/pull/10221
##########
datafusion/common/src/utils/mod.rs:
##########
@@ -1288,11 +1288,11 @@ fn truncate_list_nulls<O: OffsetSizeTrait>(
let (valid_or_empty, _nulls) = valid_or_empty.into_parts();
for (start, end) in valid_or_empty.set_slices() {
- mutable_array_data.extend(
+ mutable_array_data.try_extend(
Review Comment:
Required because `extend` and `extend_null` was deprecated
- https://github.com/apache/arrow-rs/pull/9710
(basically now errors are propagated rather than causing panics)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
