zhuqi-lucas commented on code in PR #23288:
URL: https://github.com/apache/datafusion/pull/23288#discussion_r3520713333
##########
datafusion/physical-optimizer/src/ensure_requirements/enforce_sorting/sort_pushdown.rs:
##########
@@ -356,15 +356,28 @@ fn pushdown_requirement_to_children(
return Ok(None);
};
match determine_children_requirement(&parent_required, &child_req,
child_plan) {
- RequirementsCompatibility::Satisfy =>
Ok(Some(vec![Some(child_req)])),
+ RequirementsCompatibility::Satisfy => {
Review Comment:
Thanks @aectaan for info, it makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
