killzoner commented on code in PR #1903:
URL:
https://github.com/apache/datafusion-ballista/pull/1903#discussion_r3483218236
##########
ballista/scheduler/src/state/execution_graph.rs:
##########
@@ -219,6 +219,11 @@ pub trait ExecutionGraph: Debug {
/// fail job with error message
fn fail_job(&mut self, error: String);
+ /// Abort a running job: fail it, transition every running stage to Failed,
+ /// and return the in-flight tasks that should be cancelled. Used for both
the
+ /// failure and cancellation teardown paths.
+ fn abort_running(&mut self, error: String) -> Vec<RunningTaskInfo>;
Review Comment:
Thanks that was my preference too, but i didn't want deviate from existing
conventions. I will drop/revert the commit then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
