hhhizzz commented on PR #23182: URL: https://github.com/apache/datafusion/pull/23182#issuecomment-4806482129
> I remember 5% ish noise is likely for short-running queries Yes, my point is that q23 was only about **1.14x faster on SF1**, but on my server, running **SF10 produced around a 3x speedup**. This makes me wonder whether we should require at least **SF10+ runs** before merging performance-related PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
