2010YOUY01 commented on PR #23165: URL: https://github.com/apache/datafusion/pull/23165#issuecomment-4806058751
> I am concerned about that people don't know we the aggregation have been switch to the new dev path, and will be confused about why some features don't work after updating to latest commit (actually I was confused too and found the reason finally through cpu profiling...) Functionality regressions are not expected. If they happen, that should be considered a planning bug. The new implementation is only used for functionality that has been fully migrated; otherwise, the planner falls back to the existing implementation. That said, I believe bugs/regressions are still quite likely, since the existing code has evolved over many years. If we only turn on the knob after all migrations are finished, we will likely have to fix many issues all at once. Doing this incrementally seems like a better choice. It is still not ideal, but I think it is better for DataFusion developers to find and fix these issues than for end users to encounter them unexpectedly. I agree that we should always continue improving the documentation to reduce confusion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
