github-actions[bot] commented on PR #23184: URL: https://github.com/apache/datafusion/pull/23184#issuecomment-4799218532
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v54.0.0 (current) Built [ 105.653s] (current) Parsing datafusion v54.0.0 (current) Parsed [ 0.044s] (current) Building datafusion v54.0.0 (baseline) Built [ 103.121s] (baseline) Parsing datafusion v54.0.0 (baseline) Parsed [ 0.039s] (baseline) Checking datafusion v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.888s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 211.418s] datafusion Building datafusion-physical-expr v54.0.0 (current) Built [ 28.283s] (current) Parsing datafusion-physical-expr v54.0.0 (current) Parsed [ 0.051s] (current) Building datafusion-physical-expr v54.0.0 (baseline) Built [ 29.198s] (baseline) Parsing datafusion-physical-expr v54.0.0 (baseline) Parsed [ 0.051s] (baseline) Checking datafusion-physical-expr v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.564s] 223 checks: 221 pass, 2 fail, 0 warn, 30 skip --- failure enum_variant_added: enum variant added on exhaustive enum --- Description: A publicly-visible enum without #[non_exhaustive] has a new variant. ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/enum_variant_added.ron Failed in: variant Distribution:KeyPartitioned in /home/runner/work/datafusion/datafusion/datafusion/physical-expr/src/partitioning.rs:650 --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/inherent_method_missing.ron Failed in: RangePartitioning::compatible_with, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/c519b008fd84f8f6bb5b5219ec0f7d2212d6fa60/datafusion/physical-expr/src/partitioning.rs:253 Partitioning::compatible_with, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/c519b008fd84f8f6bb5b5219ec0f7d2212d6fa60/datafusion/physical-expr/src/partitioning.rs:416 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 59.146s] datafusion-physical-expr Building datafusion-physical-optimizer v54.0.0 (current) Built [ 39.256s] (current) Parsing datafusion-physical-optimizer v54.0.0 (current) Parsed [ 0.024s] (current) Building datafusion-physical-optimizer v54.0.0 (baseline) Built [ 40.022s] (baseline) Parsing datafusion-physical-optimizer v54.0.0 (baseline) Parsed [ 0.025s] (baseline) Checking datafusion-physical-optimizer v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.173s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 81.193s] datafusion-physical-optimizer Building datafusion-physical-plan v54.0.0 (current) Built [ 37.627s] (current) Parsing datafusion-physical-plan v54.0.0 (current) Parsed [ 0.140s] (current) Building datafusion-physical-plan v54.0.0 (baseline) Built [ 37.786s] (baseline) Parsing datafusion-physical-plan v54.0.0 (baseline) Parsed [ 0.140s] (baseline) Checking datafusion-physical-plan v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.937s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 77.905s] datafusion-physical-plan Building datafusion-sqllogictest v54.0.0 (current) Built [ 184.212s] (current) Parsing datafusion-sqllogictest v54.0.0 (current) Parsed [ 0.022s] (current) Building datafusion-sqllogictest v54.0.0 (baseline) Built [ 184.190s] (baseline) Parsing datafusion-sqllogictest v54.0.0 (baseline) Parsed [ 0.023s] (baseline) Checking datafusion-sqllogictest v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.117s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 372.335s] datafusion-sqllogictest ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
