alamb commented on PR #21882: URL: https://github.com/apache/datafusion/pull/21882#issuecomment-4793870463
> From what I can see, ResourcesExhausted is exclusively caught by operators to handle memory limits (which triggers the fallback to start spilling). Conversely, hitting a disk limit during an active spill has no fallback -- it is a fatal error that simply aborts the query. Because of this, I removed the adapter's error-stashing workaround and allowed the disk quota failures to just bubble up as standard std::io::Errors with the descriptive text, since the end-user UX and control flow remain identical. i suppose we could also just define something that looked like std::io::write but had a different error type 🤮 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
