Jeadie opened a new pull request, #1892: URL: https://github.com/apache/datafusion-ballista/pull/1892
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> None ~~Closes #.~~ Suggested by @milenkovicm that we should upstream our changes (see [comment](https://github.com/spiceai/datafusion-ballista/pull/12#issuecomment-4062719622)). # Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> Useful in [spiceai/datafusion-ballista](https://github.com/spiceai/datafusion-ballista) for production features. # What changes are included in this PR? Adds an optional `available_task_slots: Option<Arc<Semaphore>>` parameter to the executor `poll_loop`. When provided, the caller supplies the semaphore that bounds concurrent task execution; when `None`, the loop creates one internally sized to the executor's task slots (unchanged behavior). Enables: - sharing the concurrency semaphore across poll loops connected to different schedulers, - observing executor busy state externally via `available_permits()`. Ported from spiceai/datafusion-ballista#14. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
