gstvg commented on code in PR #23071:
URL: https://github.com/apache/datafusion/pull/23071#discussion_r3454381250
##########
datafusion/functions-nested/src/map_extract.rs:
##########
@@ -123,6 +123,10 @@ impl ScalarUDFImpl for MapExtract {
fn coerce_types(&self, arg_types: &[DataType]) -> Result<Vec<DataType>> {
let [map_type, _] = take_function_args(self.name(), arg_types)?;
+ if map_type.is_null() {
Review Comment:
You are right, thank you. The only tested function `array_filter`
`return_type` returned the first arg type without any checks, so it obviously
passed
https://github.com/apache/datafusion/pull/23071/commits/63ab393e20abe0dffccc72ce08b99250512cd55a
Note that I also implemented null handling during execution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
