geoffreyclaude commented on issue #23073: URL: https://github.com/apache/datafusion/issues/23073#issuecomment-4768191300
This is a great refactoring suggestion! Can we just add an explicit non-performance regression gate? The `topk_sorted_tpch` benchmark in particular should stay flat (this can be checked on the PR directly by commenting `run benchmark topk_sorted_tpch`, as in https://github.com/apache/datafusion/pull/22991#issuecomment-4752736859). ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
