Phoenix500526 opened a new pull request, #23075:
URL: https://github.com/apache/datafusion/pull/23075
## Which issue does this PR close?
N/A — a trivial build-warning fix, no tracking issue.
## Rationale for this change
Building `datafusion-physical-expr` without the `proto` feature emits an
`unused import` warning:
```
warning: unused import: `internal_datafusion_err`
--> datafusion/physical-expr/src/expressions/dynamic_filters/mod.rs:26
```
`internal_datafusion_err` is only referenced inside
`impl DynamicFilterPhysicalExpr { fn try_from_proto(..) }`, which is itself
gated
behind `#[cfg(feature = "proto")]`. The import was unconditional, so it
became
dead whenever `proto` is disabled.
## What changes are included in this PR?
Move the `internal_datafusion_err` import behind `#[cfg(feature = "proto")]`
so it
is compiled only when its sole use site is, matching the existing gate on the
`try_from_proto` impl block.
## Are these changes tested?
No new tests — this is a compile-time-only change. It is exercised by
existing CI,
which builds the crate both with and without the `proto` feature; the warning
(promoted to an error under `-D warnings`) no longer fires.
## Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
