zhuqi-lucas commented on PR #22450: URL: https://github.com/apache/datafusion/pull/22450#issuecomment-4765211777
Thank you @adriangb @Dandandan @alamb for review. Merged to main branch, and the final result is good, the topk benchmark shows almost 50% reduce for the total time. https://github.com/apache/datafusion/pull/22450#issuecomment-4765161078 ```rust Comparing HEAD and feat_topk-rg-level-dynamic-pruning -------------------- Benchmark run_topk_tpch.json -------------------- ┏━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ HEAD ┃ feat_topk-rg-level-dynamic-pruning ┃ Change ┃ ┡━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ Q1 │ 2.10 / 2.57 ±0.68 / 3.92 ms │ 2.13 / 2.65 ±0.75 / 4.15 ms │ no change │ │ Q2 │ 10.45 / 10.87 ±0.53 / 11.91 ms │ 2.94 / 2.99 ±0.04 / 3.04 ms │ +3.64x faster │ │ Q3 │ 31.39 / 31.67 ±0.29 / 32.15 ms │ 31.74 / 32.30 ±0.40 / 32.91 ms │ no change │ │ Q4 │ 11.62 / 12.45 ±0.79 / 13.48 ms │ 3.24 / 3.31 ±0.08 / 3.46 ms │ +3.76x faster │ │ Q5 │ 9.80 / 10.31 ±0.32 / 10.72 ms │ 10.12 / 10.24 ±0.07 / 10.34 ms │ no change │ │ Q6 │ 16.82 / 16.85 ±0.03 / 16.90 ms │ 17.28 / 17.45 ±0.12 / 17.62 ms │ no change │ │ Q7 │ 36.31 / 37.01 ±0.66 / 38.06 ms │ 37.17 / 37.35 ±0.18 / 37.65 ms │ no change │ │ Q8 │ 27.38 / 28.15 ±0.92 / 29.80 ms │ 6.85 / 6.97 ±0.09 / 7.10 ms │ +4.04x faster │ │ Q9 │ 34.83 / 35.50 ±1.16 / 37.82 ms │ 8.28 / 8.53 ±0.29 / 9.10 ms │ +4.16x faster │ │ Q10 │ 53.00 / 53.78 ±0.96 / 55.65 ms │ 12.45 / 12.54 ±0.06 / 12.62 ms │ +4.29x faster │ │ Q11 │ 3.77 / 3.81 ±0.04 / 3.88 ms │ 3.78 / 4.16 ±0.63 / 5.42 ms │ 1.09x slower │ └───────┴────────────────────────────────┴────────────────────────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━┩ │ Total Time (HEAD) │ 242.96ms │ │ Total Time (feat_topk-rg-level-dynamic-pruning) │ 138.48ms │ │ Average Time (HEAD) │ 22.09ms │ │ Average Time (feat_topk-rg-level-dynamic-pruning) │ 12.59ms │ │ Queries Faster │ 5 │ │ Queries Slower │ 1 │ │ Queries with No Change │ 5 │ │ Queries with Failure │ 0 │ └───────────────────────────────────────────────────┴──────────┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
