crm26 commented on PR #21353: URL: https://github.com/apache/datafusion/pull/21353#issuecomment-4747659031
Thanks for the engagement — addressed all asks in the latest push. **Rebased** onto current `main` (was 695 commits behind). **@alamb** — inverted the dependency direction per your ask, matching the `datafusion-functions-spark` pattern: `datafusion` core no longer depends on `datafusion-functions-json`; the new crate has an optional `core` feature that adds the reverse dep and exposes `SessionStateBuilderJson`. README + PR body updated to document both registration paths. **@AdamGS** — all 6 inline asks applied: dropped the empty `default` feature, added empty-path (jq `.`) support, collapsed the three string match arms via `|` pattern, added a lifetime to `PathKey` to drop per-row clones, early-return on first NULL path arg, documented silent JSON-parse failure, and rewrote `extract_str_at_path` using `try_fold` per your code suggestion. **@kumarUjjawal** — your review offer is what kicked this off — appreciate it. 14 unit + 2 doctests + the json_functions.slt all green locally. Full validation matrix passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
