andygrove commented on issue #1937: URL: https://github.com/apache/datafusion-comet/issues/1937#issuecomment-4742670733
Context for the MAP checklist item: PR #4580 added a `ScalarValue::Map` arm to `spark_size_scalar` in `native/spark-expr/src/array_funcs/size.rs`, with direct Rust unit test coverage. Through SQL it's currently only reachable via constant-folded map literals, which require Map `Literal` support (this issue) or native `CreateMap` (#3167). When MAP literal support lands here, worth promoting the `size(map(...))` query in `spark/src/test/resources/sql-tests/expressions/array/size.sql` from `spark_answer_only` to default mode so the scalar arm is exercised end-to-end. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
