sandugood commented on PR #4672: URL: https://github.com/apache/datafusion-comet/pull/4672#issuecomment-4742540447
When running CI pipeline, got few UB. It was caused presumably by the `bit_offset` and `Spark` <-> `Arrow` null bitmask tinkering. Switched to a less optimal way, which still provided boost in performance. By materializing `&[bool]` and passing it to `builder`'s `append_values()` | array_type | main (current) | incoming PR | time_reduce | | ---| --- | --- | --- | | i32 | 30.030μs | 21.250μs | -29.23% | | i64 | 27.572μs | 21.996μs | -20.22% | | f64 | 30.059μs | 21.889μs | -27.17% | | date32 | 28.693μs | 21.041μs | -26.66% | | timestamp | 46.832μs | 21.888μs | -53.26% | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
