kosiew commented on code in PR #22902:
URL: https://github.com/apache/datafusion/pull/22902#discussion_r3425601749
##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -1506,20 +1506,26 @@ impl ExecutionPlan for HashJoinExec {
return Ok(None);
}
+ // TODO: split by `col`/`JoinSide` instead so mark joins can also push
down to children.
+ let is_mark_join =
Review Comment:
Small nit: `is_mark_join` is only used once here, so I think this could be a
little more direct if the `matches!` guard were inlined where the child
pushdown is skipped.
```rust
if !matches!(self.join_type(), JoinType::LeftMark | JoinType::RightMark)
&& let Some(JoinData { ... }) = try_pushdown_through_join(...)?
{
...
} else {
try_embed_projection(projection, self)
}
```
The same cleanup looks like it would apply to `NestedLoopJoinExec` too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
