Jefffrey commented on code in PR #22921:
URL: https://github.com/apache/datafusion/pull/22921#discussion_r3419694387
##########
datafusion/functions-aggregate/src/approx_distinct.rs:
##########
@@ -901,41 +731,8 @@ impl AggregateUDFImpl for ApproxDistinct {
| DataType::Int16 => {
return get_fixed_domain_approx_accumulator(data_type);
}
- DataType::UInt32 =>
Box::new(NumericHLLAccumulator::<UInt32Type>::new()),
- DataType::UInt64 =>
Box::new(NumericHLLAccumulator::<UInt64Type>::new()),
- DataType::Int32 =>
Box::new(NumericHLLAccumulator::<Int32Type>::new()),
DataType::Int64 =>
Box::new(NumericHLLAccumulator::<Int64Type>::new()),
Review Comment:
why do we keep i64 unchanged whilst using `HLLAccumulator` for other types,
including u64 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
