martin-g commented on code in PR #1852:
URL:
https://github.com/apache/datafusion-ballista/pull/1852#discussion_r3411800727
##########
ballista/core/src/execution_plans/distributed_query.rs:
##########
@@ -568,11 +569,12 @@ async fn execute_query_push(
status,
flight_proxy,
} = item;
- let job_id = status
+ let job_id: JobId = status
.as_ref()
.map(|s| s.job_id.to_owned())
- .unwrap_or("unknown_job_id".to_string()); // should not happen
- if !job_id.starts_with("unknown_") {
+ .unwrap_or("unknown_job_id".to_string()) // should not happen
Review Comment:
The idea is to postpone the String allocation until really needed.
It is not Ballista specific.
##########
ballista/core/src/lib.rs:
##########
@@ -47,6 +50,8 @@ pub mod event_loop;
pub mod execution_plans;
/// Extension traits and utilities for DataFusion integration.
pub mod extension;
+/// Strongly-typed string identifiers (job ids, job names, ...).
Review Comment:
```suggestion
/// Strongly-typed string identifiers (job ids, ...).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
