neilconway commented on code in PR #22762:
URL: https://github.com/apache/datafusion/pull/22762#discussion_r3357966718
##########
datafusion/physical-plan/src/joins/utils.rs:
##########
@@ -446,24 +449,34 @@ struct PartialJoinStatistics {
/// - Does not account for selectivity of arbitrary join filter expressions
/// (e.g., `(t1.v1 + t2.v1) % 2 = 0`). Such filters, common in
NestedLoopJoinExec,
/// are not factored into the cardinality estimation.
-/// - Column statistics for the output are simply combined from inputs without
-/// adjusting for join selectivity (acknowledged in the code as needing
-/// "filter selectivity analysis").
+/// - Column statistics for inner/outer joins are simply combined from inputs
+/// without adjusting for join selectivity (acknowledged in the code as
+/// needing "filter selectivity analysis").
Review Comment:
https://github.com/apache/datafusion/issues/22761 covers this, I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
