comphead commented on code in PR #4305:
URL: https://github.com/apache/datafusion-comet/pull/4305#discussion_r3357645907
##########
spark/src/test/resources/sql-tests/expressions/struct/structs_to_json.sql:
##########
@@ -30,8 +31,10 @@ SELECT to_json(named_struct('a', a, 'b', b, 'f', f, 'd', d))
FROM test_to_json
query
SELECT to_json(named_struct('a', 1, 'b', 'hello'))
-query expect_fallback(StructsToJson with options is not supported)
+-- to_json with options and with array fields are not supported by the native
(rust) path, so they
+-- route to the codegen (java) engine, which runs Spark's own implementation
inside Comet.
+query
Review Comment:
we need more testing, I believe to_json with structure there are lots of
hidden issues, so we need to got through all supported datatypes
Also there is the entire config set for jsons
https://spark.apache.org/docs/latest/sql-data-sources-json.html which changes
the behavior
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
