andygrove commented on PR #4583: URL: https://github.com/apache/datafusion-comet/pull/4583#issuecomment-4616068177
> Thanks @andygrove. So what's the workflow going forward for this file? Run prettier on it at release or something just to get it back into conformity? The short term answer: - Viewing this in GitHub [renders just fine](https://github.com/andygrove/datafusion-comet/blob/disable-prettier-expressions-md/docs/source/user-guide/latest/expressions.md) and viewing source is arguable more readable than having everything padded - This markdown gets published as HTML [here](https://datafusion.apache.org/comet/user-guide/latest/expressions.html) and the prettier formatting doesn't impact this - Yes, as part of the release process we do generate docs (i.e. compat guide) and run prettier so this would be prettified in release branches but not in main - I guess the question is, do we care that the version in main is not prettified? The long term answer: - I'd like to generate this from source similar to how we generate the compatibility guide, and this content would no longer exist in the markdown document, so we would no longer have conflicts. I am prototyping this now in https://github.com/apache/datafusion-comet/pull/4585 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
