andygrove commented on code in PR #4580:
URL: https://github.com/apache/datafusion-comet/pull/4580#discussion_r3350257482
##########
spark/src/test/resources/sql-tests/expressions/array/size.sql:
##########
@@ -21,7 +21,7 @@ CREATE TABLE test_size(arr array<int>, m map<string, int>)
USING parquet
statement
INSERT INTO test_size VALUES (array(1, 2, 3), map('a', 1, 'b', 2)), (array(),
map()), (NULL, NULL)
-query spark_answer_only
+query
SELECT size(arr), size(m) FROM test_size
Review Comment:
Could you also add literal map cases below the existing literal-args query?
Something like:
```sql
query
SELECT size(map('a', 1, 'b', 2)), size(map()), size(cast(NULL as
map<string,int>))
```
That way the literal path is covered for both shapes. While you're here, a
`cardinality(m)` query (Spark registers it as an alias for `size`) and a query
with `spark.sql.legacy.sizeOfNull=false` would lock down the alias and the
non-legacy null branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
