Jefffrey commented on code in PR #20945:
URL: https://github.com/apache/datafusion/pull/20945#discussion_r3346366902
##########
datafusion/expr/src/type_coercion/functions.rs:
##########
@@ -586,6 +586,50 @@ fn get_valid_types(
arguments: &[ArrayFunctionArgument],
array_coercion: Option<&ListCoercion>,
) -> Result<Vec<Vec<DataType>>> {
+ fn rebuild_array_type(
Review Comment:
probably good idea to leave a comment explaining why we do this, e.g.
```rust
// try maintain original fields where possible (avoid extraneous casts in
cast metadata/field names don't match)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
