xiedeyantu commented on PR #22564: URL: https://github.com/apache/datafusion/pull/22564#issuecomment-4608234868
@Jefffrey @kosiew I've discovered several issues with the original implementation of the log function, such as the log(1, 64) example you mentioned. I'd like to ask if we should fix all of these in this single PR? Currently, all boundary conditions are not being considered, and it seems we need a major refactoring. Therefore, I'd like to ask whether we should create a new PR for a large refactoring, or fix the issues one by one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
