avantgardnerio opened a new pull request, #22721: URL: https://github.com/apache/datafusion/pull/22721
## Which issue does this PR close? Follow-up to #22626 (allocator-level memory tracking in SLTs). ## Rationale for this change `HEADROOM_FACTOR` in the SLT accounting pool is currently 8.0 — i.e. we accept allocator usage up to 8× the pool's declared limit before failing. That's loose enough to hide real leaks. Lowering it to 5.0 surfaces an untracked allocation in `nested_loop_join_spill.slt`. At 5× headroom, the first query in that suite allocates ~3.7 MB against a declared 150K limit. `NestedLoopJoinExec` has untracked allocation in at least three sites — `generate_next_batch` buffering, `concat_batches` at the spill boundary, and `take_native` during probe — plus the IPC reader path on spill re-read. ## What changes are included in this PR? One constant change in `datafusion/sqllogictest/src/accounting_pool.rs`: `HEADROOM_FACTOR: f64 = 8.0` → `5.0`, with updated doc comment. ## Are these changes tested? CI is the test — `nested_loop_join_spill.slt` is expected to fail until the operator-side leaks are fixed. That's the intended signal of this PR, not a regression. ## Are there any user-facing changes? No. Test-infrastructure-only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
