andygrove opened a new pull request, #4574:
URL: https://github.com/apache/datafusion-comet/pull/4574
## Which issue does this PR close?
<!-- No tracking issue; small documentation consistency fix. -->
N/A
## Rationale for this change
The `expressions.md` reference page had two inconsistencies:
1. **Conflicting definition of the ⚠️ marker.** The introduction described
⚠️ as "Supported (caveats)" whose divergent cases fall back to Spark by default
and must be opted into with `allowIncompatible`. The status legend (and the
actual ⚠️ rows, `array_size` and `try_make_timestamp`) define ⚠️ as "Incorrect
by default": Comet runs natively by default and can return results that differ
from Spark. The two definitions contradicted each other. The "falls back by
default + allowIncompatible opt-in" behavior actually applies to certain ✅
expressions (for example `cast`, `array_except`), not to ⚠️ expressions.
2. **Inconsistent issue and pull request references.** The Notes column
mixed bare references (such as `tracking #4098` and `(#4288)`) with full
Markdown links. These docs render via Sphinx, where bare `#NNNN` references do
not autolink, so the bare ones were not clickable.
## What changes are included in this PR?
- Rewrote the introduction so the ⚠️ description matches the status legend
("Incorrect by default"), and described the `allowIncompatible` opt-in
separately as a property of certain ✅ expressions.
- Converted every bare issue/PR reference in the tables to a full Markdown
link (`[#NNNN](https://github.com/apache/datafusion-comet/issues/NNNN)`) for
consistency with the references that were already linked.
- Reran `prettier` to realign the affected tables (the bulk of the line
count change is column re-padding).
## How are these changes tested?
Documentation-only change. `prettier --check "**/*.md"` passes, matching the
CI formatting check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
