Copilot commented on code in PR #22660: URL: https://github.com/apache/datafusion/pull/22660#discussion_r3338092252
########## benchmarks/sql_benchmarks/h2o/init/load_groupby_medium_csv.sql: ########## @@ -0,0 +1 @@ +CREATE EXTERNAL TABLE x STORED AS CSV LOCATION 'data/h2o/G1_1e8_1e8_100_0.csv'; Review Comment: These load scripts hard-code the data root as `data/…` and therefore ignore the benchmark framework’s `DATA_DIR` environment variable. This makes the benchmark fail when users run with `DATA_DIR` set (as supported by the SQL benchmark harness). ########## benchmarks/sql_benchmarks/h2o/init/load_groupby_small_parquet.sql: ########## @@ -0,0 +1 @@ +CREATE EXTERNAL TABLE x STORED AS PARQUET LOCATION 'data/h2o/G1_1e7_1e7_100_0.parquet'; Review Comment: These load scripts hard-code the data root as `data/…` and therefore ignore the benchmark framework’s `DATA_DIR` environment variable. This makes the benchmark fail when users run with `DATA_DIR` set (as supported by the SQL benchmark harness). ########## benchmarks/sql_benchmarks/h2o/init/load_groupby_small_csv.sql: ########## @@ -0,0 +1 @@ +CREATE EXTERNAL TABLE x STORED AS CSV LOCATION 'data/h2o/G1_1e7_1e7_100_0.csv'; Review Comment: These load scripts hard-code the data root as `data/…` and therefore ignore the benchmark framework’s `DATA_DIR` environment variable. This makes the benchmark fail when users run with `DATA_DIR` set (as supported by the SQL benchmark harness). ########## benchmarks/sql_benchmarks/h2o/init/load_groupby_medium_parquet.sql: ########## @@ -0,0 +1 @@ +CREATE EXTERNAL TABLE x STORED AS PARQUET LOCATION 'data/h2o/G1_1e8_1e8_100_0.parquet'; Review Comment: These load scripts hard-code the data root as `data/…` and therefore ignore the benchmark framework’s `DATA_DIR` environment variable. This makes the benchmark fail when users run with `DATA_DIR` set (as supported by the SQL benchmark harness). ########## benchmarks/sql_benchmarks/h2o/init/load_groupby_big_parquet.sql: ########## @@ -0,0 +1 @@ +CREATE EXTERNAL TABLE x STORED AS PARQUET LOCATION 'data/h2o/G1_1e9_1e9_100_0.parquet'; Review Comment: These load scripts hard-code the data root as `data/…` and therefore ignore the benchmark framework’s `DATA_DIR` environment variable. This makes the benchmark fail when users run with `DATA_DIR` set (as supported by the SQL benchmark harness). ########## benchmarks/sql_benchmarks/h2o/init/load_groupby_big_csv.sql: ########## @@ -0,0 +1 @@ +CREATE EXTERNAL TABLE x STORED AS CSV LOCATION 'data/h2o/G1_1e9_1e9_100_0.csv'; Review Comment: These load scripts hard-code the data root as `data/…` and therefore ignore the benchmark framework’s `DATA_DIR` environment variable. This makes the benchmark fail when users run with `DATA_DIR` set (as supported by the SQL benchmark harness). ########## benchmarks/sql_benchmarks/h2o/init/load_window_small_parquet.sql: ########## @@ -0,0 +1 @@ +CREATE EXTERNAL TABLE x STORED AS PARQUET LOCATION 'data/h2o/J1_1e7_1e7_NA.parquet'; Review Comment: These load scripts hard-code the data root as `data/…` and therefore ignore the benchmark framework’s `DATA_DIR` environment variable. This makes the benchmark fail when users run with `DATA_DIR` set (as supported by the SQL benchmark harness). ########## benchmarks/sql_benchmarks/h2o/init/load_window_small_csv.sql: ########## @@ -0,0 +1 @@ +CREATE EXTERNAL TABLE x STORED AS CSV LOCATION 'data/h2o/J1_1e7_1e7_NA.csv'; Review Comment: These load scripts hard-code the data root as `data/…` and therefore ignore the benchmark framework’s `DATA_DIR` environment variable. This makes the benchmark fail when users run with `DATA_DIR` set (as supported by the SQL benchmark harness). ########## benchmarks/sql_benchmarks/h2o/init/load_window_medium_parquet.sql: ########## @@ -0,0 +1 @@ +CREATE EXTERNAL TABLE x STORED AS PARQUET LOCATION 'data/h2o/J1_1e8_1e8_NA.parquet'; Review Comment: These load scripts hard-code the data root as `data/…` and therefore ignore the benchmark framework’s `DATA_DIR` environment variable. This makes the benchmark fail when users run with `DATA_DIR` set (as supported by the SQL benchmark harness). ########## benchmarks/sql_benchmarks/h2o/init/load_window_medium_csv.sql: ########## @@ -0,0 +1 @@ +CREATE EXTERNAL TABLE x STORED AS CSV LOCATION 'data/h2o/J1_1e8_1e8_NA.csv'; Review Comment: These load scripts hard-code the data root as `data/…` and therefore ignore the benchmark framework’s `DATA_DIR` environment variable. This makes the benchmark fail when users run with `DATA_DIR` set (as supported by the SQL benchmark harness). ########## benchmarks/sql_benchmarks/h2o/init/load_window_big_csv.sql: ########## @@ -0,0 +1 @@ +CREATE EXTERNAL TABLE x STORED AS CSV LOCATION 'data/h2o/J1_1e9_1e9_NA.csv'; Review Comment: These load scripts hard-code the data root as `data/…` and therefore ignore the benchmark framework’s `DATA_DIR` environment variable. This makes the benchmark fail when users run with `DATA_DIR` set (as supported by the SQL benchmark harness). ########## benchmarks/sql_benchmarks/h2o/init/load_window_big_parquet.sql: ########## @@ -0,0 +1 @@ +CREATE EXTERNAL TABLE x STORED AS PARQUET LOCATION 'data/h2o/J1_1e9_1e9_NA.parquet'; Review Comment: These load scripts hard-code the data root as `data/…` and therefore ignore the benchmark framework’s `DATA_DIR` environment variable. This makes the benchmark fail when users run with `DATA_DIR` set (as supported by the SQL benchmark harness). ########## benchmarks/sql_benchmarks/h2o/init/load_join_small_parquet.sql: ########## @@ -0,0 +1,7 @@ +CREATE EXTERNAL TABLE x STORED AS PARQUET LOCATION 'data/h2o/J1_1e7_NA_0.parquet'; + +CREATE EXTERNAL TABLE small STORED AS PARQUET LOCATION 'data/h2o/J1_1e7_1e1_0.parquet'; + +CREATE EXTERNAL TABLE medium STORED AS PARQUET LOCATION 'data/h2o/J1_1e7_1e4_0.parquet'; Review Comment: These load scripts hard-code the data root as `data/…` and therefore ignore the benchmark framework’s `DATA_DIR` environment variable. This makes the benchmark fail when users run with `DATA_DIR` set (as supported by the SQL benchmark harness). ########## benchmarks/sql_benchmarks/h2o/init/load_join_small_csv.sql: ########## @@ -0,0 +1,7 @@ +CREATE EXTERNAL TABLE x STORED AS CSV LOCATION 'data/h2o/J1_1e7_NA_0.csv'; + +CREATE EXTERNAL TABLE small STORED AS CSV LOCATION 'data/h2o/J1_1e7_1e1_0.csv'; + +CREATE EXTERNAL TABLE medium STORED AS CSV LOCATION 'data/h2o/J1_1e7_1e4_0.csv'; Review Comment: These load scripts hard-code the data root as `data/…` and therefore ignore the benchmark framework’s `DATA_DIR` environment variable. This makes the benchmark fail when users run with `DATA_DIR` set (as supported by the SQL benchmark harness). ########## benchmarks/sql_benchmarks/h2o/init/load_join_medium_parquet.sql: ########## @@ -0,0 +1,7 @@ +CREATE EXTERNAL TABLE x STORED AS PARQUET LOCATION 'data/h2o/J1_1e8_NA_0.parquet'; + +CREATE EXTERNAL TABLE small STORED AS PARQUET LOCATION 'data/h2o/J1_1e8_1e2_0.parquet'; + +CREATE EXTERNAL TABLE medium STORED AS PARQUET LOCATION 'data/h2o/J1_1e8_1e5_0.parquet'; Review Comment: These load scripts hard-code the data root as `data/…` and therefore ignore the benchmark framework’s `DATA_DIR` environment variable. This makes the benchmark fail when users run with `DATA_DIR` set (as supported by the SQL benchmark harness). ########## benchmarks/sql_benchmarks/h2o/init/load_join_big_parquet.sql: ########## @@ -0,0 +1,7 @@ +CREATE EXTERNAL TABLE x STORED AS PARQUET LOCATION 'data/h2o/J1_1e9_NA_0.parquet'; + +CREATE EXTERNAL TABLE small STORED AS PARQUET LOCATION 'data/h2o/J1_1e9_1e3_0.parquet'; + +CREATE EXTERNAL TABLE medium STORED AS PARQUET LOCATION 'data/h2o/J1_1e9_1e6_0.parquet'; Review Comment: These load scripts hard-code the data root as `data/…` and therefore ignore the benchmark framework’s `DATA_DIR` environment variable. This makes the benchmark fail when users run with `DATA_DIR` set (as supported by the SQL benchmark harness). ########## benchmarks/sql_benchmarks/h2o/init/load_join_medium_csv.sql: ########## @@ -0,0 +1,7 @@ +CREATE EXTERNAL TABLE x STORED AS CSV LOCATION 'data/h2o/J1_1e8_NA_0.csv'; + +CREATE EXTERNAL TABLE small STORED AS CSV LOCATION 'data/h2o/J1_1e8_1e2_0.csv'; + +CREATE EXTERNAL TABLE medium STORED AS CSV LOCATION 'data/h2o/J1_1e8_1e5_0.csv'; Review Comment: These load scripts hard-code the data root as `data/…` and therefore ignore the benchmark framework’s `DATA_DIR` environment variable. This makes the benchmark fail when users run with `DATA_DIR` set (as supported by the SQL benchmark harness). ########## benchmarks/sql_benchmarks/h2o/init/load_join_big_csv.sql: ########## @@ -0,0 +1,7 @@ +CREATE EXTERNAL TABLE x STORED AS CSV LOCATION 'data/h2o/J1_1e9_NA_0.csv'; + +CREATE EXTERNAL TABLE small STORED AS CSV LOCATION 'data/h2o/J1_1e9_1e3_0.csv'; + +CREATE EXTERNAL TABLE medium STORED AS CSV LOCATION 'data/h2o/J1_1e9_1e6_0.csv'; Review Comment: These load scripts hard-code the data root as `data/…` and therefore ignore the benchmark framework’s `DATA_DIR` environment variable. This makes the benchmark fail when users run with `DATA_DIR` set (as supported by the SQL benchmark harness). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
