zhuqi-lucas commented on PR #22518:
URL: https://github.com/apache/datafusion/pull/22518#issuecomment-4589900721

   ```rust
   Comparing HEAD and feat_adaptive-partial-agg-cost
   --------------------
   Benchmark clickbench_partitioned.json
   --------------------
   
┏━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
   ┃ Query     ┃                                  HEAD ┃        
feat_adaptive-partial-agg-cost ┃        Change ┃
   
┡━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
   │ QQuery 0  │          1.17 / 3.34 ±4.25 / 11.83 ms │          1.14 / 3.29 
±4.23 / 11.75 ms │     no change │
   │ QQuery 1  │        12.32 / 12.61 ±0.15 / 12.76 ms │        12.27 / 12.44 
±0.11 / 12.59 ms │     no change │
   │ QQuery 2  │        37.36 / 37.77 ±0.34 / 38.27 ms │        35.36 / 35.49 
±0.10 / 35.64 ms │ +1.06x faster │
   │ QQuery 3  │        30.56 / 31.18 ±0.73 / 32.56 ms │        30.32 / 30.91 
±0.58 / 31.86 ms │     no change │
   │ QQuery 4  │     217.32 / 225.61 ±4.50 / 230.31 ms │     223.99 / 228.51 
±4.02 / 235.21 ms │     no change │
   │ QQuery 5  │     271.84 / 272.96 ±1.13 / 275.00 ms │     269.06 / 272.86 
±3.23 / 278.74 ms │     no change │
   │ QQuery 6  │           1.21 / 1.37 ±0.22 / 1.81 ms │           1.19 / 1.33 
±0.22 / 1.77 ms │     no change │
   │ QQuery 7  │        13.67 / 13.90 ±0.15 / 14.14 ms │        13.47 / 13.60 
±0.12 / 13.81 ms │     no change │
   │ QQuery 8  │     322.25 / 324.53 ±1.40 / 326.23 ms │     328.43 / 334.54 
±5.88 / 344.74 ms │     no change │
   │ QQuery 9  │     450.16 / 460.34 ±5.67 / 467.69 ms │     453.37 / 457.68 
±4.15 / 464.43 ms │     no change │
   │ QQuery 10 │        70.35 / 71.34 ±1.31 / 73.81 ms │        68.43 / 69.34 
±0.90 / 71.05 ms │     no change │
   │ QQuery 11 │        81.33 / 82.24 ±0.63 / 82.99 ms │        79.31 / 82.94 
±4.20 / 90.84 ms │     no change │
   │ QQuery 12 │     267.56 / 271.45 ±4.82 / 280.54 ms │     252.57 / 257.43 
±4.83 / 265.76 ms │ +1.05x faster │
   │ QQuery 13 │    367.76 / 381.85 ±12.93 / 402.12 ms │    365.01 / 384.32 
±10.59 / 393.64 ms │     no change │
   │ QQuery 14 │     283.06 / 288.48 ±3.92 / 295.06 ms │     263.34 / 270.42 
±6.25 / 282.12 ms │ +1.07x faster │
   │ QQuery 15 │     268.74 / 278.37 ±8.76 / 294.84 ms │    272.85 / 287.43 
±10.55 / 300.34 ms │     no change │
   │ QQuery 16 │     617.11 / 625.76 ±7.43 / 635.84 ms │     623.04 / 634.20 
±9.25 / 648.78 ms │     no change │
   │ QQuery 17 │     627.71 / 632.41 ±3.23 / 636.98 ms │     630.08 / 639.96 
±5.09 / 644.44 ms │     no change │
   │ QQuery 18 │ 1283.02 / 1298.71 ±14.43 / 1317.55 ms │ 1154.04 / 1178.13 
±23.21 / 1221.30 ms │ +1.10x faster │
   │ QQuery 19 │        27.71 / 29.71 ±2.74 / 35.08 ms │        27.34 / 30.33 
±5.80 / 41.92 ms │     no change │
   │ QQuery 20 │    522.81 / 529.99 ±12.84 / 555.65 ms │     519.88 / 530.27 
±7.52 / 542.37 ms │     no change │
   │ QQuery 21 │     591.07 / 598.98 ±6.97 / 609.35 ms │     600.87 / 605.06 
±2.84 / 609.08 ms │     no change │
   │ QQuery 22 │ 1055.47 / 1075.82 ±12.08 / 1088.38 ms │  1062.53 / 1068.55 
±8.11 / 1084.60 ms │     no change │
   │ QQuery 23 │ 3179.33 / 3225.05 ±37.69 / 3277.19 ms │ 3196.57 / 3222.36 
±23.59 / 3262.97 ms │     no change │
   │ QQuery 24 │        41.83 / 42.33 ±0.75 / 43.83 ms │        41.87 / 43.29 
±1.31 / 45.37 ms │     no change │
   │ QQuery 25 │     110.94 / 119.64 ±8.85 / 135.62 ms │     110.05 / 111.82 
±1.57 / 114.18 ms │ +1.07x faster │
   │ QQuery 26 │        42.23 / 43.06 ±1.04 / 45.12 ms │        42.18 / 43.78 
±1.28 / 45.41 ms │     no change │
   │ QQuery 27 │     665.70 / 674.49 ±6.41 / 682.96 ms │     669.53 / 676.11 
±5.39 / 685.78 ms │     no change │
   │ QQuery 28 │ 3063.68 / 3092.00 ±20.32 / 3118.35 ms │  3049.25 / 3061.70 
±7.34 / 3072.13 ms │     no change │
   │ QQuery 29 │        40.67 / 43.02 ±2.74 / 47.21 ms │        40.57 / 40.94 
±0.52 / 41.97 ms │     no change │
   │ QQuery 30 │     297.29 / 304.68 ±5.06 / 309.85 ms │     288.40 / 293.81 
±7.50 / 307.87 ms │     no change │
   │ QQuery 31 │     291.36 / 296.65 ±6.12 / 305.65 ms │    283.37 / 301.79 
±10.07 / 313.40 ms │     no change │
   │ QQuery 32 │    939.77 / 967.00 ±17.77 / 993.27 ms │    938.61 / 961.70 
±16.16 / 988.08 ms │     no change │
   │ QQuery 33 │ 1454.51 / 1486.96 ±28.06 / 1530.69 ms │ 1424.97 / 1475.42 
±32.40 / 1522.52 ms │     no change │
   │ QQuery 34 │ 1496.09 / 1536.82 ±42.50 / 1600.63 ms │ 1436.06 / 1487.34 
±39.41 / 1546.92 ms │     no change │
   │ QQuery 35 │    279.77 / 296.72 ±11.89 / 314.93 ms │    289.82 / 313.47 
±36.44 / 385.03 ms │  1.06x slower │
   │ QQuery 36 │        65.35 / 72.89 ±5.86 / 81.06 ms │        56.27 / 69.12 
±8.20 / 81.21 ms │ +1.05x faster │
   │ QQuery 37 │        35.51 / 40.80 ±5.36 / 47.79 ms │        35.81 / 40.26 
±4.98 / 46.91 ms │     no change │
   │ QQuery 38 │        39.65 / 49.26 ±6.71 / 58.63 ms │        41.00 / 42.45 
±1.38 / 44.89 ms │ +1.16x faster │
   │ QQuery 39 │    145.29 / 157.18 ±10.74 / 175.16 ms │     112.92 / 118.85 
±4.01 / 124.11 ms │ +1.32x faster │
   │ QQuery 40 │        13.88 / 18.11 ±5.39 / 28.29 ms │        14.35 / 16.51 
±2.33 / 19.48 ms │ +1.10x faster │
   │ QQuery 41 │        13.44 / 14.77 ±1.78 / 18.25 ms │        13.16 / 14.86 
±2.95 / 20.74 ms │     no change │
   │ QQuery 42 │        12.92 / 13.13 ±0.16 / 13.40 ms │        12.80 / 14.34 
±2.77 / 19.86 ms │  1.09x slower │
   
└───────────┴───────────────────────────────────────┴───────────────────────────────────────┴───────────────┘
   ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
   ┃ Benchmark Summary                             ┃            ┃
   ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
   │ Total Time (HEAD)                             │ 20043.29ms │
   │ Total Time (feat_adaptive-partial-agg-cost)   │ 19778.96ms │
   │ Average Time (HEAD)                           │   466.12ms │
   │ Average Time (feat_adaptive-partial-agg-cost) │   459.98ms │
   │ Queries Faster                                │          9 │
   │ Queries Slower                                │          2 │
   │ Queries with No Change                        │         32 │
   │ Queries with Failure                          │          0 │
   └───────────────────────────────────────────────┴────────────┘
   ```
   
   cc @alamb @Dandandan @adriangb 
   The clickbench result is good, and it can be reproduced.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to